viridian: make viridian_time_domain_freeze() safe to call...
authorPaul Durrant <paul.durrant@citrix.com>
Wed, 21 Aug 2019 08:22:58 +0000 (09:22 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 21 Aug 2019 10:16:40 +0000 (11:16 +0100)
commit40f6da82800d5a23212ec3ccc4819b77ea0a9980
treede740b5906fd0d6e41af33258764c3bb02626e70
parent77a994f3f8eb0d3cb0f2bf314b0ebf6a1d37f623
viridian: make viridian_time_domain_freeze() safe to call...

...on a partially destroyed domain.

viridian_time_domain_freeze() and viridian_time_vcpu_freeze() rely
(respectively) on the dynamically allocated per-domain and per-vcpu viridian
areas [1], which are freed during domain_relinquish_resources().
Because arch_domain_pause() can call viridian_domain_time_freeze() this
can lead to host crashes if e.g. a XEN_DOMCTL_pausedomain is issued after
domain_relinquish_resources() has run.

To prevent such crashes, this patch adds a check of is_dying into
viridian_time_domain_freeze(), and viridian_time_domain_thaw() which is
similarly vulnerable to indirection into freed memory.

NOTE: The patch also makes viridian_time_vcpu_freeze/thaw() static, since
      they have no callers outside of the same source module.

[1] See commit e7a9b5e72f26 "viridian: separately allocate domain and vcpu
    structures".

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
xen/arch/x86/hvm/viridian/time.c